How to improve the velocity for coworkers doing Code Reviews?
Situation:
I am a software developer working for a US company we have a process for code reviews and we usually need to pass 2 filters before checking in the code to the branch, for the 1st filter our team leader created small groups of developers, so each one of us send the CR to other team members and at the same time acts as a reviewer for somebody else.
We usually have to wait 24 hours after we send the code review to either ask the team members to check it, on the other hand we are given 24 hours to review the CRs sent to us, (which is really high for me, since we should do this within the first 8 hours after the CR is sent, at the beginning of the day or before leaving should be a good time to do it, I mean is not so difficult since we usually work with small tasks), 1st problem appears here, because almost everyone takes 16-24 before taking a look on the code.
For the second filter we need to add one more reviewer to gives us the final approbation, and here is when the real problem comes, our main boss is in charge of the final revision, he is a really busy person, and I mean really, with meetings all the day, different projects to take a look on, different team leaders to attend and everybody's final code review, he says we need to wait 48 hrs for him before ask him to do it. he also says that if somebody else needs our code then we can check the code in and leave the CR open, but I think this could lead to get more problems, because if he says we have some code that is wrong the we are affecting everyone that uses our code.
Problem:
If we add the 16-24 (1st filter) to the 48 hours that the boss takes to review our code (sometimes even more) we have an extremely high amount of time before anything can be checked in, sometimes a code that sent to CR on Monday is being checked in the next Monday!, and if we consider that we are working on tasks related to each other then is more difficult once we need to check the code in.
Question:
I would like to improve this process, I want to find out a way to approach either my leader or the boss to improve this.
software-industry management colleagues code
asked 10 mins ago
UnnamedUnnamed
1
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
Situation:
I am a software developer working for a US company we have a process for code reviews and we usually need to pass 2 filters before checking in the code to the branch, for the 1st filter our team leader created small groups of developers, so each one of us send the CR to other team members and at the same time acts as a reviewer for somebody else.
We usually have to wait 24 hours after we send the code review to either ask the team members to check it, on the other hand we are given 24 hours to review the CRs sent to us, (which is really high for me, since we should do this within the first 8 hours after the CR is sent, at the beginning of the day or before leaving should be a good time to do it, I mean is not so difficult since we usually work with small tasks), 1st problem appears here, because almost everyone takes 16-24 before taking a look on the code.
For the second filter we need to add one more reviewer to gives us the final approbation, and here is when the real problem comes, our main boss is in charge of the final revision, he is a really busy person, and I mean really, with meetings all the day, different projects to take a look on, different team leaders to attend and everybody's final code review, he says we need to wait 48 hrs for him before ask him to do it. he also says that if somebody else needs our code then we can check the code in and leave the CR open, but I think this could lead to get more problems, because if he says we have some code that is wrong the we are affecting everyone that uses our code.
Problem:
If we add the 16-24 (1st filter) to the 48 hours that the boss takes to review our code (sometimes even more) we have an extremely high amount of time before anything can be checked in, sometimes a code that sent to CR on Monday is being checked in the next Monday!, and if we consider that we are working on tasks related to each other then is more difficult once we need to check the code in.
Question:
I would like to improve this process, I want to find out a way to approach either my leader or the boss to improve this.
software-industry management colleagues code
asked 10 mins ago
UnnamedUnnamed
1
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
Situation:
I am a software developer working for a US company we have a process for code reviews and we usually need to pass 2 filters before checking in the code to the branch, for the 1st filter our team leader created small groups of developers, so each one of us send the CR to other team members and at the same time acts as a reviewer for somebody else.
We usually have to wait 24 hours after we send the code review to either ask the team members to check it, on the other hand we are given 24 hours to review the CRs sent to us, (which is really high for me, since we should do this within the first 8 hours after the CR is sent, at the beginning of the day or before leaving should be a good time to do it, I mean is not so difficult since we usually work with small tasks), 1st problem appears here, because almost everyone takes 16-24 before taking a look on the code.
For the second filter we need to add one more reviewer to gives us the final approbation, and here is when the real problem comes, our main boss is in charge of the final revision, he is a really busy person, and I mean really, with meetings all the day, different projects to take a look on, different team leaders to attend and everybody's final code review, he says we need to wait 48 hrs for him before ask him to do it. he also says that if somebody else needs our code then we can check the code in and leave the CR open, but I think this could lead to get more problems, because if he says we have some code that is wrong the we are affecting everyone that uses our code.
Problem:
If we add the 16-24 (1st filter) to the 48 hours that the boss takes to review our code (sometimes even more) we have an extremely high amount of time before anything can be checked in, sometimes a code that sent to CR on Monday is being checked in the next Monday!, and if we consider that we are working on tasks related to each other then is more difficult once we need to check the code in.
Question:
I would like to improve this process, I want to find out a way to approach either my leader or the boss to improve this.
software-industry management colleagues code
asked 10 mins ago
UnnamedUnnamed
1
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Situation:
I am a software developer working for a US company we have a process for code reviews and we usually need to pass 2 filters before checking in the code to the branch, for the 1st filter our team leader created small groups of developers, so each one of us send the CR to other team members and at the same time acts as a reviewer for somebody else.
We usually have to wait 24 hours after we send the code review to either ask the team members to check it, on the other hand we are given 24 hours to review the CRs sent to us, (which is really high for me, since we should do this within the first 8 hours after the CR is sent, at the beginning of the day or before leaving should be a good time to do it, I mean is not so difficult since we usually work with small tasks), 1st problem appears here, because almost everyone takes 16-24 before taking a look on the code.
For the second filter we need to add one more reviewer to gives us the final approbation, and here is when the real problem comes, our main boss is in charge of the final revision, he is a really busy person, and I mean really, with meetings all the day, different projects to take a look on, different team leaders to attend and everybody's final code review, he says we need to wait 48 hrs for him before ask him to do it. he also says that if somebody else needs our code then we can check the code in and leave the CR open, but I think this could lead to get more problems, because if he says we have some code that is wrong the we are affecting everyone that uses our code.
Problem:
If we add the 16-24 (1st filter) to the 48 hours that the boss takes to review our code (sometimes even more) we have an extremely high amount of time before anything can be checked in, sometimes a code that sent to CR on Monday is being checked in the next Monday!, and if we consider that we are working on tasks related to each other then is more difficult once we need to check the code in.
Question:
I would like to improve this process, I want to find out a way to approach either my leader or the boss to improve this.
software-industry management colleagues code
software-industry management colleagues code
asked 10 mins ago
UnnamedUnnamed
1
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 mins ago
UnnamedUnnamed
1
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 mins ago
UnnamedUnnamed
1
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 mins ago
UnnamedUnnamed
1
asked 10 mins ago
UnnamedUnnamed
1
1
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Unnamed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "423"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
noCode: true, onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Unnamed is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f129322%2fhow-to-improve-the-velocity-for-coworkers-doing-code-reviews%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Unnamed is a new contributor. Be nice, and check out our Code of Conduct.
Unnamed is a new contributor. Be nice, and check out our Code of Conduct.
Unnamed is a new contributor. Be nice, and check out our Code of Conduct.
Unnamed is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to The Workplace Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f129322%2fhow-to-improve-the-velocity-for-coworkers-doing-code-reviews%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
